GHSA-5jfw-35xp-5m42 json
Buffer length underflow in LoginPacket causing unchecked exceptions to be thrown
published 4y ago modified last yr.
- cvss
- 7.5
- version 3.1, GitHub
- cisa kev
- Not listed
- not in CISA's catalog
- epss
- —
- no score, EPSS covers CVEs only
- public exploits
- 0
- none known
Summary
### Impact `LoginPacket` uses `BinaryStream->getLInt()` to read the lengths of JSON payloads it wants to decode. Unfortunately, `BinaryStream->getLInt()` returns a signed integer, meaning that a malicious client can craft a packet with a large uint32 value for payload buffer size (which would be interpreted as a negative signed int32), causing `BinaryStream->get()` to throw an exception.
In the context of PocketMine-MP, this leads to a server crash when the vulnerability is exploited.
### Patches e3fce7632b94e83fd6a518a87dcaf6a11681c4ac
### Workarounds This can be worked around by registering a custom `LoginPacket` implementation into `PacketPool` which overrides [this code](https://github.com/pmmp/BedrockProtocol/blob/47532c95ea37d5f0365b23f734d70d943ff95295/src/LoginPacket.php#L54) to patch it.
### For more information * Email us at [team@pmmp.io](mailto:team@pmmp.io)
Patch / fix
Is GHSA-5jfw-35xp-5m42 in your dependencies? Fencer shows which of your repositories are affected as soon as an advisory lands, and opens the fix as a pull request.
Check with FencerCVSS scores
| assigned by | version | score | vector |
|---|---|---|---|
| GitHub | 3.1 | 7.5 | CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H |
Affected packages
| ecosystem | package | affected | fixed in |
|---|---|---|---|
| packagist | pocketmine/bedrock-protocol | <8.0.2 |
8.0.2 |
Classification
- Weakness
-
- CWE-124 Buffer Underwrite
References
Sources
- GitHub Advisory GHSA-5jfw-35xp-5m42
Fencer Intel keeps one entry per vulnerability: the CVE id wins, then GHSA, and records that alias each other are merged, except that two CVEs always keep separate entries. The same data is available as JSON.