GHSA-7vw7-qx38-37vr json
Propel2 SQL injection possible with limit() on MySQL
published 2y ago modified last yr.
- cvss
- 9.8
- version 3.1, GitHub
- cisa kev
- Not listed
- not in CISA's catalog
- epss
- —
- no score, EPSS covers CVEs only
- public exploits
- 0
- none known
Summary
The limit() query method is susceptible to catastrophic SQL injection with MySQL.
For example, given a model User for a table users: ``` UserQuery::create()->limit('1;DROP TABLE users')->find(); ``` This will drop the users table!
The cause appears to be a lack of integer casting of the limit input in either Propel\Runtime\ActiveQuery\Criteria::setLimit() or in Propel\Runtime\Adapter\Pdo\MysqlAdapter::applyLimit(). The code comments there seem to imply that casting was avoided due to overflow issues with 32-bit integers.
This is surprising behavior since one of the primary purposes of an ORM is to prevent basic SQL injection.
This affects all versions of Propel: 1.x, 2.x, and 3.
Patch / fix
- packagist propel/propel 2.0.0-alpha8
- github.com/propelorm/Propel2@cd23d73 commit
- github.com/propelorm/Propel2#1464 pull request
Is GHSA-7vw7-qx38-37vr in your dependencies? Fencer shows which of your repositories are affected as soon as an advisory lands, and opens the fix as a pull request.
Check with FencerCVSS scores
| assigned by | version | score | vector |
|---|---|---|---|
| GitHub | 3.1 | 9.8 | CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H |
Affected packages
| ecosystem | package | affected | fixed in |
|---|---|---|---|
| packagist | propel/propel | >=2.0.0-alpha1, <2.0.0-alpha8 |
2.0.0-alpha8 |
Classification
- Weakness
-
- CWE-89 Improper Neutralization of Special Elements used in an SQL Command
References
-
github.com
/propelorm/Propel2/pull/1464
web
-
github.com
/propelorm/Propel2/commit/cd23d7384a15cfe203e23b3a835c8ab1d81d9246
web
-
github.com
/propelorm/Propel2/issues/1463
web
-
github.com
/FriendsOfPHP/security-advisories/blob/master/propel/propel/2018-02-14.yaml
web
-
github.com
/propelorm/Propel2
package
Sources
- GitHub Advisory GHSA-7vw7-qx38-37vr
Fencer Intel keeps one entry per vulnerability: the CVE id wins, then GHSA, and records that alias each other are merged, except that two CVEs always keep separate entries. The same data is available as JSON.