GHSA-8mj7-wxmc-f424 json
Use after free in Neon external buffers
published 4y ago modified 3y ago also RUSTSEC-2022-0028
- cvss
- —
- not scored
- cisa kev
- Not listed
- not in CISA's catalog
- epss
- —
- no score, EPSS covers CVEs only
- public exploits
- 0
- none known
Summary
Neon provides functionality for creating JavaScript `ArrayBuffer` (and the `Buffer` subtype) instances backed by bytes allocated outside of V8/Node. The [`JsArrayBuffer::external`](https://docs.rs/neon/0.10.0/neon/types/struct.JsArrayBuffer.html#method.external) and [`JsBuffer::external`](https://docs.rs/neon/0.10.0/neon/types/struct.JsBuffer.html#method.external) did not require `T: 'static` prior to Neon `0.10.1`. This allowed creating an externally backed buffer from types that may be freed while they are still referenced by a JavaScript `ArrayBuffer`.
The following example demonstrates use after free. It compiles on versions `<0.10.1` and fails to compile afterward.
```rust pub fn soundness_hole(mut cx: FunctionContext) -> JsResult<JsArrayBuffer> { let mut data = vec![0u8, 1, 2, 3];
// Creating an external from `&mut [u8]` instead of `Vec<u8>` since there is a blanket impl // of `AsMut<T> for &mut T` let buf = JsArrayBuffer::external(&mut cx, data.as_mut_slice());
// `buf` is still holding a reference to `data`! drop(data);
Ok(buf) } ```
Patch / fix
- crates.io neon 0.10.1
Is GHSA-8mj7-wxmc-f424 in your dependencies? Fencer shows which of your repositories are affected as soon as an advisory lands, and opens the fix as a pull request.
Check with FencerAffected packages
| ecosystem | package | affected | fixed in |
|---|---|---|---|
| crates.io | neon | >=0.8.0, <0.10.1 |
0.10.1 |
References
-
github.com
/neon-bindings/neon/issues/896
web, report
-
github.com
/neon-bindings/neon
package
-
rustsec.org
/advisories/RUSTSEC-2022-0028.html
web, advisory
-
crates.io
/crates/neon
package
Sources
- GitHub Advisory GHSA-8mj7-wxmc-f424
- OSV RUSTSEC-2022-0028
Fencer Intel keeps one entry per vulnerability: the CVE id wins, then GHSA, and records that alias each other are merged, except that two CVEs always keep separate entries. The same data is available as JSON.