Skip to content
Fencer Intel
high —

GHSA-ff5x-w9wg-h275 json

Holder can generate proof of ownership for credentials it does not control in vp-toolkit

published 6y ago modified 6y ago

cvss
—
not scored
cisa kev
Not listed
not in CISA's catalog
epss
—
no score, EPSS covers CVEs only
public exploits
0
none known

Summary

### Impact The [`verifyVerifiablePresentation()`](https://github.com/rabobank-blockchain/vp-toolkit/blob/master/src/service/signers/verifiable-presentation-signer.ts#L97) method check the cryptographic integrity of the Verifiable Presentation, but it does not check if the [`credentialSubject.id`](https://github.com/rabobank-blockchain/vp-toolkit-models/blob/develop/src/model/verifiable-credential.ts#L150) DID matches the signer of the VP proof.

The **verifier** is impacted by this vulnerability.

### Patches Patch will be available in version 0.2.2.

### Workarounds - Compute the address out of the `verifiablePresentation.proof.n.verificationMethod` using `getAddressFromPubKey()` from `crypt-util@0.1.5` and match it with the `credentialSubject.id` address from the credential.

### References [Github issue](https://github.com/rabobank-blockchain/vp-toolkit/issues/14)

### For more information If you have any questions or comments about this advisory: * Discuss in the existing [issue](https://github.com/rabobank-blockchain/vp-toolkit/issues/14) * [Contact me](https://github.com/rabomarnix)

Patch / fix

  • npm vp-toolkit 0.2.2

Is GHSA-ff5x-w9wg-h275 in your dependencies? Fencer shows which of your repositories are affected as soon as an advisory lands, and opens the fix as a pull request.

Check with Fencer

Affected packages

ecosystem package affected fixed in
npm vp-toolkit
<0.2.2
0.2.2

References

Sources

Fencer Intel keeps one entry per vulnerability: the CVE id wins, then GHSA, and records that alias each other are merged, except that two CVEs always keep separate entries. The same data is available as JSON.