GHSA-m6w8-fq7v-ph4m json
GovernorCompatibilityBravo incorrect ABI encoding may lead to unexpected behavior
published 4y ago modified 4y ago
- cvss
- —
- not scored
- cisa kev
- Not listed
- not in CISA's catalog
- epss
- —
- no score, EPSS covers CVEs only
- public exploits
- 0
- none known
Summary
### Impact
The `GovernorCompatibilityBravo` module may lead to the creation of governance proposals that execute function calls with incorrect arguments due to bad ABI encoding. This happens if the proposal is created using explicit function signatures, e.g. a proposal to invoke the function `foo(uint256)` is created as `propose([target], [0], ["foo(uint256)"], ["0x00..01"])`. If the function selector is provided as part of the encoded proposal data the issue is not present, e.g. the same proposal is created as `propose([target], [0], ["0x2fbebd3800..01"])`, where `2fbebd38` is the function selector.
We've assessed the instances of this contract found on chain, and did not find any occurrence of this bug in the past. Proposal creation through Tally or OpenZeppelin Defender is not affected. The core `Governor` contract on its own is not affected.
### Patches
A fix is included in version v4.4.2 of `@openzeppelin/contracts` and `@openzeppelin/contracts-upgradeable`.
### Workarounds
Do not create proposals using explicit function signatures. Instead, use the `propose` function without the `signatures` argument, and create the proposal using the fully ABI-encoded function call including the function selector in the `calldatas` argument as explained above.
### References
https://github.com/OpenZeppelin/openzeppelin-contracts/issues/3099
### Credits
This issue was identified and reported by @GeraldHost.
### For more information
If you have any questions, comments, or need assistance regarding this advisory, email us at security@openzeppelin.com.
To submit security reports please use [our bug bounty on Immunefi](https://immunefi.com/bounty/openzeppelin/).
Patch / fix
- npm @openzeppelin/contracts 4.4.2
- npm @openzeppelin/contracts-upgradeable 4.4.2
Is GHSA-m6w8-fq7v-ph4m in your dependencies? Fencer shows which of your repositories are affected as soon as an advisory lands, and opens the fix as a pull request.
Check with FencerAffected packages
| ecosystem | package | affected | fixed in |
|---|---|---|---|
| npm | @openzeppelin/contracts | >=4.3.0, <4.4.2 |
4.4.2 |
| npm | @openzeppelin/contracts-upgradeable | >=4.3.0, <4.4.2 |
4.4.2 |
References
Sources
- GitHub Advisory GHSA-m6w8-fq7v-ph4m
- Maintainer advisory GHSA-m6w8-fq7v-ph4m
Fencer Intel keeps one entry per vulnerability: the CVE id wins, then GHSA, and records that alias each other are merged, except that two CVEs always keep separate entries. The same data is available as JSON.
The maintainers of OpenZeppelin/openzeppelin-contracts published their own advisory on GitHub. Reviewed sources take precedence over it.