GHSA-pqhp-25j4-6hq9 json
smol-toml has a Denial of Service via malicious TOML document using deeply nested inline tables
published last yr. modified last yr.
- cvss
- 5.3
- version 3.1, GitHub
- cisa kev
- Not listed
- not in CISA's catalog
- epss
- —
- no score, EPSS covers CVEs only
- public exploits
- 0
- none known
Summary
### Summary An attacker can send a maliciously crafted TOML to cause the parser to crash because of a stack overflow caused by a deeply nested inline structure. A similar problem occurs when attempting to stringify deeply nested objects.
The library does not limit the maximum exploration depth while parsing or producing TOML documents, nor does it offer a way to do so.
### Proof of concept ```js require("smol-toml").parse("e=" + "{e=".repeat(9999) + "{}" + "}".repeat(9999)) ```
### Impact Applications which parse arbitrary TOML documents may suffer availability issues if they receive malicious input. If uncaught, the crash may cause the application itself to crash. The impact is deemed minor, as the function is already likely to throw errors on invalid input and therefore to properly handle errors.
Due to the design of most JavaScript runtimes, the uncontrolled recursion does not lead to excessive memory usage and the execution is quickly aborted.
As a reminder, it is **strongly** advised when working with untrusted user input to expect errors to occur and to appropriately catch them.
### Patches Version 1.3.1 offers a mechanism to limit the exploration depth before halting with a `TomlError` when parsing, with a default cap of 1000. A same mechanism has been implemented for stringifying objects.
**Please note that the parser will *still* throw an error upon such cases.** It is, however, a now-controlled and documented behavior of the library.
### Workarounds Wrap all invocations of `parse` and `stringify` in a try/catch block.
Patch / fix
Is GHSA-pqhp-25j4-6hq9 in your dependencies? Fencer shows which of your repositories are affected as soon as an advisory lands, and opens the fix as a pull request.
Check with FencerCVSS scores
| assigned by | version | score | vector |
|---|---|---|---|
| GitHub | 3.1 | 5.3 | CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L |
Affected packages
| ecosystem | package | affected | fixed in |
|---|---|---|---|
| npm | smol-toml | <1.3.1 |
1.3.1 |
Classification
- Weakness
-
- CWE-674 Uncontrolled Recursion
References
Sources
- GitHub Advisory GHSA-pqhp-25j4-6hq9
- Maintainer advisory GHSA-pqhp-25j4-6hq9
Fencer Intel keeps one entry per vulnerability: the CVE id wins, then GHSA, and records that alias each other are merged, except that two CVEs always keep separate entries. The same data is available as JSON.
The maintainers of squirrelchat/smol-toml published their own advisory on GitHub. Reviewed sources take precedence over it.